Support CUDA 12.2#1419
Merged
rapids-bot[bot] merged 18 commits intorapidsai:branch-24.04from Feb 9, 2024
jameslamb:test-cuda-12.2
Merged
Support CUDA 12.2#1419rapids-bot[bot] merged 18 commits intorapidsai:branch-24.04from jameslamb:test-cuda-12.2
rapids-bot[bot] merged 18 commits intorapidsai:branch-24.04from
jameslamb:test-cuda-12.2
Conversation
5 tasks
ajschmidt8
approved these changes
Jan 8, 2024
4 tasks
bdice
reviewed
Jan 11, 2024
jameslamb
changed the title
bdice
approved these changes
Jan 11, 2024
Collaborator
bdice
left a comment
bdice
left a comment
There was a problem hiding this comment.
Looks good to me. I'll mark this as DO NOT MERGE until we get more of RAPIDS passing and we decide whether to target 24.02 or 24.04.
7 tasks
jameslamb
changed the title
We should not use the cuda-cudart-dev package in host as a means of getting a run_export of cuda-cudart in run, because it enforces an equal or greater version of cuda-cudart at runtime. This breaks CUDA minor version compatibility, where we intend to build a package with e.g. CUDA 12.2, and allow it to be run with e.g. CUDA 12.0.
This reverts commit d4f8aa2.
bdice
approved these changes
Feb 6, 2024
Collaborator
bdice
left a comment
bdice
left a comment
There was a problem hiding this comment.
I verified that builds and tests appear to be using the correct CUDA versions now. xref: rapidsai/build-planning#8 (comment)
vyasr
approved these changes
Feb 9, 2024
AyodeAwe
approved these changes
Feb 9, 2024
Collaborator
|
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Feb 20, 2024
Follow-up to #1419 For all GitHub Actions configs, replaces uses of the `test-cuda-12.2` branch on `shared-workflows` with `branch-24.04`, now that rapidsai/shared-workflows#166 has been merged. ### Notes for Reviewers This is part of ongoing work to build and test packages against CUDA 12.2 across all of RAPIDS. For more details see: * rapidsai/build-planning#7 *(created with `rapids-reviser`)* Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Ray Douglass (https://github.com/raydouglass) URL: #1468
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Notes for Reviewers
This is part of ongoing work to build and test packages against CUDA 12.2.2 across all of RAPIDS.
For more details see:
Checklist
Notes for Reviewers
Planning a second round of PRs to revert these references back to a proper
branch-24.{nn}release branch ofshared-workflowsonce rapidsai/shared-workflows#166 is merged.